Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI job & patch build on Windows #135

Merged
merged 3 commits into from Oct 7, 2020
Merged

Add CI job & patch build on Windows #135

merged 3 commits into from Oct 7, 2020

Conversation

atodorov
Copy link
Contributor

@atodorov atodorov commented Oct 7, 2020

No description provided.

@atodorov atodorov force-pushed the test_on_windows branch 2 times, most recently from ed82c72 to bd878a5 Compare October 7, 2020 10:00
@codecov-io
Copy link

codecov-io commented Oct 7, 2020 •
edited

Codecov Report

Merging #135 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #135   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines         2277      2277           
=========================================
  Hits          2277      2277
Flag Coverage Δ
#unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c62f14...3765172. Read the comment docs.

@atodorov atodorov force-pushed the test_on_windows branch 9 times, most recently from 22a3825 to 4fbc3a4 Compare October 7, 2020 10:51
@atodorov
Add CI job to install on Windows. Refs python-bugzilla#134
6de27cc 
will fail with:

     running install
     running build
     Didn't find rst2man or rst2man.py

ERROR: Command errored out with exit status 1: ...
@atodorov atodorov marked this pull request as ready for review October 7, 2020 11:00
@atodorov
Copy link
Contributor Author

atodorov commented Oct 7, 2020

Here you can see the failure from the 1st commit b/c rst2man can't be found:
https://github.com/python-bugzilla/python-bugzilla/pull/135/checks?check_run_id=1219972012

with the latest commit all looks good even on Windows.

@crobinso can you please review.

@atodorov atodorov changed the title Add CI job to build & install on Windows. Refs #134 Add CI job & patch build on Windows Oct 7, 2020
@atodorov
Use shutil.which() instead of find_executable(). Refs python-bugzilla…
2224f36 
…#134

unfortunately this doesn't seem to work
@atodorov
Install without man pages if rst2man not found. Fixes python-bugzilla…
dd33704 
…#134

Prior to 68a1dc6 the man page
generation was skipped if it failed, which worked fine for users
on both Windows and Linux where rst2man was missing.

This commit brings back the same behavior.
@atodorov
Copy link
Contributor Author

atodorov commented Oct 7, 2020

Replaced with shutil.which() but that still seems not to work:
https://github.com/python-bugzilla/python-bugzilla/pull/135/checks?check_run_id=1221797263

@crobinso crobinso merged commit b376719 into python-bugzilla:master Oct 7, 2020
@crobinso
Copy link
Member

crobinso commented Oct 7, 2020

Yup I just tried that too. Thanks for the CI additions! I'll take this as is

@atodorov atodorov deleted the test_on_windows branch October 7, 2020 17:18
@atodorov
Copy link
Contributor Author

atodorov commented Oct 7, 2020

Yup I just tried that too. Thanks for the CI additions! I'll take this as is

Many thanks. Do you mind pushing a 3.0.1 version to PyPI ?

@crobinso
Copy link
Member

crobinso commented Oct 7, 2020

Sure I'll do that by the end of the day

@crobinso
Copy link
Member

crobinso commented Oct 7, 2020

Uploaded now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atodorov @codecov-io @crobinso