Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround for requests < 2.0 on python 3 #3

Merged
merged 1 commit into from Aug 9, 2015

Conversation

abn
Copy link
Contributor

@abn abn commented Jul 23, 2015

  • this workaround caused systems with ndg-httpsclient installed to
    error out when requests is used
  • requests versions 0.14.2 to 1.2.3 do not work due to unrelated issues
    and hence no point carrying this workaround
[abn@zoidberg temp]$ pip list
pip (6.0.8)
python-bugzilla (1.2.1)
requests (1.0.0)
setuptools (12.0.5)
[abn@zoidberg temp]$ ./temp/bin/bugzilla login foo foo
__init__() got an unexpected keyword argument 'strict'


[abn@zoidberg temp]$ pip list
pip (6.0.8)
python-bugzilla (1.2.1)
requests (1.2.3)
setuptools (12.0.5)
[abn@zoidberg temp]$ ./temp/bin/bugzilla login foo foo
__init__() got an unexpected keyword argument 'strict'
  • requests version 0.14.1 and earlier works without this workaround
[abn@zoidberg temp]$ pip list
pip (6.0.8)
python-bugzilla (1.2.1)
requests (0.14.1)
setuptools (12.0.5)
[abn@zoidberg temp]$ ./temp/bin/bugzilla login foo foo
[14:39:18] INFO (bugzilla:1160) Connecting to https://bugzilla.redhat.com/xmlrpc.cgi
[14:39:18] INFO (bugzilla:1163) Autodetecting Bugzilla type
[14:39:18] INFO (__init__:46) Using RHBugzilla for URL containing bugzilla.redhat.com
[14:39:18] INFO (__init__:114) Chose subclass RHBugzilla v0.1
[14:39:18] INFO (base:672) Using username/password for authentication
[14:39:18] INFO (base:680) Logging in... 
Login failed: The username or password you entered is not valid.

- this workaround caused systems with ndg-httpsclient installed to
  error out when requests is used
- requests versions 0.14.2 to 1.2.3 do not work due to unrelated issues
  and hence no point carrying this workaround
- requests version 0.14.1 and earlier works without this workaround
@abn
Copy link
Contributor Author

abn commented Jul 23, 2015

Commenting on the requests issue; kennethreitz/requests@2c5b020#diff-56e4c9a9f8955a91d87d7da5335a7dddR545 introduces the 'strict' kwarg in the VerifiedHTTPSConnection initialization but the VerifiedHTTPSConnection class definition is unaware of it.

@crobinso crobinso merged commit 71fb59e into python-bugzilla:master Aug 9, 2015
@crobinso
Copy link
Member

crobinso commented Aug 9, 2015

Thanks Arun, pulled this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants