Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global defaults including enable/disable #120

Merged
merged 5 commits into from Apr 3, 2023
Merged

Conversation

lordjabez
Copy link
Contributor

@lordjabez lordjabez commented Apr 1, 2023

Adds new set_default_params function to allow setting of global defaults. See description in README and function header for details.

Also adds enable_caching and disable_caching functions so caching can be turned on or off across all decorators at any time.

Fixes #56
Fixes #100
Fixes #117

@lordjabez lordjabez temporarily deployed to test April 1, 2023 03:46 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 1, 2023 03:46 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to checkdocs April 1, 2023 03:46 — with GitHub Actions Inactive
@lordjabez lordjabez requested a review from shaypal5 April 1, 2023 03:46
@lordjabez lordjabez temporarily deployed to test April 1, 2023 03:46 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 1, 2023 03:46 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 1, 2023 03:46 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 1, 2023 03:46 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 1, 2023 03:46 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 1, 2023 03:46 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 1, 2023 03:46 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 1, 2023 03:46 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 1, 2023 03:46 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 1, 2023 03:46 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 1, 2023 03:46 — with GitHub Actions Inactive
@lordjabez lordjabez self-assigned this Apr 1, 2023
@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Merging #120 (f737168) into master (45c11aa) will increase coverage by 1.67%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #120      +/-   ##
===========================================
+ Coverage   98.32%   100.00%   +1.67%     
===========================================
  Files           5         5              
  Lines         477       494      +17     
  Branches       76        79       +3     
===========================================
+ Hits          469       494      +25     
+ Misses          5         0       -5     
+ Partials        3         0       -3     
Impacted Files Coverage Δ
cachier/base_core.py 100.00% <100.00%> (ø)
cachier/core.py 100.00% <100.00%> (+3.81%) ⬆️
cachier/memory_core.py 100.00% <100.00%> (ø)
cachier/mongo_core.py 100.00% <100.00%> (+3.12%) ⬆️
cachier/pickle_core.py 100.00% <100.00%> (+0.52%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45c11aa...f737168. Read the comment docs.

@lordjabez lordjabez temporarily deployed to test April 3, 2023 04:21 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 3, 2023 04:21 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 3, 2023 04:21 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 3, 2023 04:21 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 3, 2023 04:21 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 3, 2023 04:21 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 3, 2023 04:21 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 3, 2023 04:21 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 3, 2023 04:21 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 3, 2023 04:21 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 3, 2023 04:21 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to checkdocs April 3, 2023 04:21 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 3, 2023 04:21 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 3, 2023 04:21 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 3, 2023 04:21 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 3, 2023 04:21 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 3, 2023 04:21 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 3, 2023 04:21 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 3, 2023 04:21 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 3, 2023 04:21 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 3, 2023 04:21 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 3, 2023 04:21 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 3, 2023 04:21 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 3, 2023 04:21 — with GitHub Actions Inactive
@lordjabez lordjabez temporarily deployed to test April 3, 2023 04:21 — with GitHub Actions Inactive
Copy link
Collaborator

@shaypal5 shaypal5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read through this! Looks great, and very extensively tested! Nice one, Judson! :)

@lordjabez lordjabez merged commit 7bd2c77 into master Apr 3, 2023
31 checks passed
@lordjabez lordjabez deleted the global-defaults branch April 3, 2023 13:40
@lordjabez
Copy link
Contributor Author

@shaypal5 do you have an idea when you'll get a new release out with this PR? I've got some "day job" work blocked on being able to pull it into a CI/CD pipeline from PyPI. And yes I realize there are workarounds to that, but I'd rather just get it the official way.

@shaypal5
Copy link
Collaborator

shaypal5 commented Apr 9, 2023

Released as v2.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants