Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce type hints #251

Closed
tobixen opened this issue Jan 15, 2023 · 2 comments
Closed

Introduce type hints #251

tobixen opened this issue Jan 15, 2023 · 2 comments
Labels
good first issue help wanted
Milestone
v.1.x

Comments

@tobixen
Copy link
Member

tobixen commented Jan 15, 2023 •
edited
Loading

We ought to use type hints - though this depends on python2-support to be officially dropped (PR #228), this has been deliberately postponed as python2 is still supported by some OS distributions.

Help is wanted, I learned python while 2.4 was bleeding edge, type hints is new to me. It's not needed to introduce type hints everywhere in one operation, pull requests that only takes parts and bits will be accepted.
@tobixen tobixen modified the milestones: vx.x, v.1.1 Jan 15, 2023
@sim0nx
Copy link
Contributor

sim0nx commented Dec 19, 2023

I guess this one can be closed with the merge of #358

@tobixen
Copy link
Member Author

tobixen commented Dec 19, 2023

Oh, a duplicate of #328? Thanks for pointing out.

@tobixen tobixen closed this as completed Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
v.1.x
Development

No branches or pull requests
2 participants
@tobixen @sim0nx