Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python2 support #228

Merged
merged 4 commits into from
Feb 18, 2023
Merged

Drop python2 support #228

merged 4 commits into from
Feb 18, 2023

Conversation

danigm
Copy link
Contributor

@danigm danigm commented Nov 3, 2022

Python 2 went EOL on 1/1/2020 and we receive no more support from the Python Core Team after Python 2.7.18 even for known security issues.

This removes the six package from dependencies.

@tobixen
Copy link
Member

tobixen commented Nov 3, 2022

Currently the caldav library is in a bit of a limbo status when it comes to python2, at one hand there is code in place to support python2, at the other hand I haven't done any testing towards python2 for quite some releases now - so the python2-support there is is likely to be broken. From one perspective "no support" may be better than "probably broken support" My official stance on this is that if I get bug reports that it breaks on python2, I will still fix it.

While python2 isn't maintained by the Python core team, it still exists as a package for Ubuntu 20.04 which is EOL'ed in 2030 - and 2.7 is the default python version in CentOS7, which is EOL'ed in 2024. Theoretically, Canonical and RedHat are supposed to take the responsibility of patching up python if some security issue should appear.

Everything considered, this pull request will be put on hold for some time - perhaps not all the way until 2030, but at least until 2024 :-)

bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Nov 4, 2022
https://build.opensuse.org/request/show/1033143
by user dgarcia + dimstar_suse
- Add drop-python2-support.patch to remove python-six dependency
  gh#python-caldav/caldav#228
- Remove python_module macro definition
- Update to 0.10.0
  ## Quick summary
  * Work on a universal search method
    * Refactoring, consolidated lots of slightly duplicated code into one
      method to rule them all
    * Support for things needed by the calendar-cli utility, like search by
      categories
  * Support for completion of recurring tasks
  * More utilities for tasks
    * Uncomplete-method ... for undoing the complete (recurrences not supported
      though)
    * get/set duration/dtstart/dtend (arguably this belongs to vobject and/or
      icalendar)
  * Other improvements:
    * picklable URLs
    * display_name convenience method
    * possible to set child/parent relationshi
tobixen added a commit that referenced this pull request Dec 3, 2022
tobixen added a commit that referenced this pull request Dec 3, 2022
tobixen added a commit that referenced this pull request Jan 5, 2023
tobixen added a commit that referenced this pull request Jan 14, 2023
tobixen added a commit that referenced this pull request Jan 14, 2023
@tobixen tobixen mentioned this pull request Jan 15, 2023
@tobixen
Copy link
Member

tobixen commented Jan 15, 2023

Came to think, python2-support must have been efficiently broken for some time already due to dependencies on other libraries.

I will make a release (1.0) within some few days, as soon as I'm done with that I will roll out this pull request - unless there will be a queue of hard-code dinosaur python2-users protesting.

@tobixen tobixen added this pull request to the merge queue Feb 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 18, 2023
@tobixen tobixen added this pull request to the merge queue Feb 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 18, 2023
@tobixen tobixen added this pull request to the merge queue Feb 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 18, 2023
danigm and others added 3 commits February 18, 2023 10:39
Python 2 went EOL on 1/1/2020 and we receive no more support from the
Python Core Team after Python 2.7.18 even for known security issues.

This removes the six package from dependencies.
@tobixen tobixen added this pull request to the merge queue Feb 18, 2023
Merged via the queue into python-caldav:master with commit 641305d Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants