Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing custom HTTP headers #285

Closed
JasonSanDiego opened this issue Feb 21, 2023 · 3 comments
Closed

Support passing custom HTTP headers #285

JasonSanDiego opened this issue Feb 21, 2023 · 3 comments

Comments

@JasonSanDiego
Copy link
Contributor

I'm using Nextcloud and want to retrieve calendar (read only) subscriptions along with the normal read/write calendars. Nextcloud supports two ways of doing this. The easier of the two is to pass the custom HTTP header: X-NC-CalDAV-Webcal-Caching: On

More details

Are folks open to adding this functionality by modfying the DAVclient initialization function to have an optional header parameter?

Example use:
client = caldav.DAVClient(..., headers={"X-NC-CalDAV-Webcal-Caching": "On"})

If so, I can file a pull request with this small change.

@tobixen
Copy link
Member

tobixen commented Feb 21, 2023

Pull request is appreciated.

@tobixen
Copy link
Member

tobixen commented Feb 26, 2023

The feature will be released in 1.2 shortly. However, the issue should not be closed, we're missing documentation and test code.

@tobixen
Copy link
Member

tobixen commented Jul 19, 2023

This was fixed in #306 indeed. Thanks. Will be released in 1.3 today, I hope.

@tobixen tobixen closed this as completed Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants