-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extract_auth_types - shortening strings #289
Comments
Weird - I would have expected some of my test servers to fail, and people from the homeassistant community to be whining a lot if basic auth was broken. This code section seems to be missing unit tests, so I'll try to write up some and possibly see if I can reproduce the problem. |
I can reproduce it. |
This bug has been there since 1.0 actually, it wasn't introduced in 1.1. I suppose almost all servers with basic auth have a realm in the header. |
@jdrozdnovak ... It would be nice if you could test and see if the master branch solves the problem for you - or, if it's possible to make me a testing account on your caldav server allowing me to test it myself it would be great. Since this is a considered to be a critical bugfix, I will roll out a new minor-release soon - I should just run the test code first towards a handful of servers. Anyway, I'm pretty sure the fix does not break anything. |
I can tomorrow test it with master and let you know. docker run --name some-monica -d -p 8080:80 monica |
Ok, thanks |
I tested it with the code in master branch and that works fine. |
I'm running tests and will release 1.1.4 during the day probably |
thank you very much! Have great sunday! |
Hello
This lambda function https://github.com/python-caldav/caldav/blob/master/caldav/davclient.py#L553 not works ideally when having simple headers like
www-authenticate: Basic
I don't know enough about other caldav environments to do a change myself. I have only 2 available for test.
what the
extract_auth_types
returns in my case is['basi']
which fails the future"basic" in auth_type
conditionThanks for reviewing.
The text was updated successfully, but these errors were encountered: