Skip to content

Commit

Permalink
Merge branch 'fix-msvc2012-build-error'
Browse files Browse the repository at this point in the history
* fix-msvc2012-build-error:
  Conditionally replace semicolon with escaped char to fix VS2010/VS2012 errors
  • Loading branch information
jcfr committed Apr 10, 2013
2 parents a70729f + 1d5731a commit 22a0870
Showing 1 changed file with 12 additions and 4 deletions.
16 changes: 12 additions & 4 deletions cmake/libpython/CMakeLists.txt
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -152,6 +152,14 @@ if(UNIX)
PYTHONPATH="${EXTRA_PYTHONPATH}:lib-dynload:plat-${PY_PLATFORM}" PYTHONPATH="${EXTRA_PYTHONPATH}:lib-dynload:plat-${PY_PLATFORM}"
) )
elseif(WIN32) elseif(WIN32)
# HACK To workaround limitation in escaping logic of CMake, the pythonpath
# separator is conditionally set depending of the version of Visual Studio.
# See http://cmake.org/Bug/view.php?id=14073
if("${MSVC_VERSION}" VERSION_GREATER "1599")
set(PATHSEP "%3B")
else()
set(PATHSEP ";")
endif()
list(APPEND LIBPYTHON_SOURCES list(APPEND LIBPYTHON_SOURCES
${SRC_DIR}/PC/dl_nt.c ${SRC_DIR}/PC/dl_nt.c
${SRC_DIR}/PC/getpathp.c ${SRC_DIR}/PC/getpathp.c
Expand All @@ -161,10 +169,10 @@ elseif(WIN32)
string(REPLACE "/" "\\\\" PYTHONHOME_ESCAPED ${PYTHONHOME}) string(REPLACE "/" "\\\\" PYTHONHOME_ESCAPED ${PYTHONHOME})
string(REPLACE "/" "\\\\" EXTENSION_INSTALL_DIR_ESCAPED ${EXTENSION_INSTALL_DIR}) string(REPLACE "/" "\\\\" EXTENSION_INSTALL_DIR_ESCAPED ${EXTENSION_INSTALL_DIR})
set(PYTHONPATH "${EXTRA_PYTHONPATH}") set(PYTHONPATH "${EXTRA_PYTHONPATH}")
set(PYTHONPATH "${PYTHONPATH};.\\\\${PYTHONHOME_ESCAPED}") set(PYTHONPATH "${PYTHONPATH}${PATHSEP}.\\\\${PYTHONHOME_ESCAPED}")
set(PYTHONPATH "${PYTHONPATH};.\\\\${EXTENSION_INSTALL_DIR_ESCAPED}") set(PYTHONPATH "${PYTHONPATH}${PATHSEP}.\\\\${EXTENSION_INSTALL_DIR_ESCAPED}")
set(PYTHONPATH "${PYTHONPATH};.\\\\${EXTENSION_INSTALL_DIR_ESCAPED}\\\\${CMAKE_CFG_INTDIR}") set(PYTHONPATH "${PYTHONPATH}${PATHSEP}.\\\\${EXTENSION_INSTALL_DIR_ESCAPED}\\\\${CMAKE_CFG_INTDIR}")
set(PYTHONPATH "${PYTHONPATH};.\\\\${PYTHONHOME_ESCAPED}\\\\plat-${PY_PLATFORM}") set(PYTHONPATH "${PYTHONPATH}${PATHSEP}.\\\\${PYTHONHOME_ESCAPED}\\\\plat-${PY_PLATFORM}")
set_property( set_property(
SOURCE ${SRC_DIR}/PC/getpathp.c SOURCE ${SRC_DIR}/PC/getpathp.c
PROPERTY COMPILE_DEFINITIONS PROPERTY COMPILE_DEFINITIONS
Expand Down

0 comments on commit 22a0870

Please sign in to comment.