Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable looking for libutil on Android #320

Closed
wants to merge 4 commits into from

Conversation

esnosy
Copy link

@esnosy esnosy commented Jan 26, 2023

No description provided.

@jcfr
Copy link
Contributor

jcfr commented Jan 26, 2023

Thanks for the patch 🙏

I am considering integrating this approach currently associated with #280

+if(CMAKE_SYSTEM MATCHES "^Android")
+  set(LIBUTIL_EXPECTED 0)
+  set(HAVE_LIBUTIL 0)
+endif()

How does that sound ?

Additionally, would you have any feedback related to #280 (Initial Android Support: alternate)?

@esnosy
Copy link
Author

esnosy commented Jan 26, 2023

Both approaches work great 🙏 ,
I guess I can wait for the other patch to be merged, I will try to use the other patch on my local repo, currently trying to compile Python for Android using this repo, will give feedback if I have any issue with it

@esnosy esnosy closed this Jan 26, 2023
@esnosy
Copy link
Author

esnosy commented Jan 26, 2023

closing as the other patch already includes this functionality

@jcfr jcfr mentioned this pull request Jan 26, 2023
3 tasks
@esnosy esnosy reopened this Jan 27, 2023
@esnosy esnosy closed this Jan 27, 2023
@esnosy esnosy reopened this Jan 28, 2023
@esnosy esnosy closed this Jan 29, 2023
@esnosy esnosy deleted the android branch June 30, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants