update workflow to pass jobname to python-control pytest #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnavigator
reviewed
Dec 25, 2022
| @@ -283,7 +283,9 @@ jobs: | |||
| pip install slycot-wheels/${{ matrix.packagekey }}/slycot*.whl | |||
| pip show slycot | |||
| - name: Slycot and python-control tests | |||
| run: bash slycot-src/.github/scripts/run-tests.sh | |||
| run: JOBNAME=$JOBNAME bash slycot-src/.github/scripts/run-tests.sh | |||
There was a problem hiding this comment.
I am surprised that this works without quotes around $JOBNAME as there is a space in the value.
|
Added quotes just to be safe + added the build type (pip/wheel vs conda) so that we only xfail on conda. This PR will generate errors until python-control master is updated to check the build type (coming soon). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR passes information about the current OS and BLAS version that is being used in slycot testing to python-control unit tests to avoid generating errors on known failure modes. This allows the changes in python-control PR #821 to xfail on configurations that were causing errors (outside of slycot functionality).
A better fix would be to somehow set up the python-control unit tests to only run those that rely on slycot functions when using for slycot testing. But I couldn't think of an easy way to do that.