Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate poles more smarter for state-space systems #84

Closed
cwrowley opened this issue Apr 19, 2016 · 1 comment
Closed

Calculate poles more smarter for state-space systems #84

cwrowley opened this issue Apr 19, 2016 · 1 comment
Labels
quickfix

Comments

@cwrowley
Copy link
Contributor

As pointed out by @pmli in #27, the current implementation involves unnecessarily computing the characteristic polynomial, and then finding its roots. This is inefficient and numerically unstable. Much better to use np.linalg.eigvals.
@mp4096 mp4096 mentioned this issue May 20, 2016
Merged
murrayrm added a commit that referenced this issue May 30, 2016
@murrayrm
Merge pull request #91 from mp4096/master
6dfd5a5 
Addressing #84 and #85
@murrayrm
Copy link
Member

Addressed in PR #91, now merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
quickfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@murrayrm @cwrowley