implementation of initial_phase, wrap_phase keywords for bode() #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnavigator
requested changes
Jan 1, 2021
bnavigator
approved these changes
Jan 2, 2021
murrayrm
added a commit
to murrayrm/python-control
that referenced
this pull request
Jan 4, 2021
…on-control#494) * implementation of initial_phase, wrap_phase keywords for bode() * add additional documentation on initial_phase if deg=False * clear figure in unit tests to avoid slow plotting problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
initial_phaseandwrap_phasekeywords tobode, which allow you to tune the behavior of the phase portion of a Bode plot. The default behavior should more or less match previous behavior, except that the default initial phase will be between 0 and -360 degrees (so 1/s^3 will start with phase -270).Resolves issue #467.