Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: add bdschur, which calls Slycot mb03rd. Change modal_form to us… #495

Merged
merged 4 commits into from Jan 15, 2021
Merged

ENH: add bdschur, which calls Slycot mb03rd. Change modal_form to us… #495

merged 4 commits into from Jan 15, 2021

Conversation

roryyorke
Copy link
Contributor

…e bdschur

The bdschur interface is modelled after the Matlab function of the
same name; it can also optionally sort the modal blocks.

Added tests for bdschur, and modified tests for modal_form.

Closes #318

@coveralls
Copy link

coveralls commented Jan 1, 2021 •
edited

Coverage Status

Coverage increased (+0.1%) to 87.648% when pulling 8fc3627 on roryyorke:rory/modal-form into feb9fc9 on python-control:master.

bnavigator
bnavigator reviewed Jan 1, 2021
View reviewed changes
Copy link
Contributor

@bnavigator bnavigator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Some comments about the docstrings and test suite. Can't say much about the algorithms themselves.

control/canonical.py Outdated Show resolved Hide resolved
control/canonical.py Outdated Show resolved Hide resolved
control/canonical.py Outdated Show resolved Hide resolved
control/tests/canonical_test.py Show resolved Hide resolved
@roryyorke
Copy link
Contributor Author

Thanks @bnavigator ! I've added the @slycotonly decorator, and updated the docs. I did some minor mods to the other docstrings in canonical.py too, and added bdschur and modal_form to control.rst.

roryyorke and others added 4 commits January 14, 2021 21:45
@roryyorke @murrayrm
ENH: add bdschur, which calls Slycot mb03rd. Change modal_form to use…
14079fb 
… bdschur

The bdschur interface is modelled after the Matlab function of the
same name; it can also optionally sort the modal blocks.

Added tests for bdschur, and modified tests for modal_form.
@roryyorke @murrayrm
Change docstrings to numpydoc conventions; update doc func index
f630b4a
@roryyorke @murrayrm
Add @slycotonly decorator as needed
7122b07
@murrayrm
update _convertToStateSpace to _convert_to_statespace
8fc3627
@murrayrm
Copy link
Member

Rebased and changed _convertToStateSpace to _convert_to_statespace. Will merge as soon as Travis finishes up.

@murrayrm murrayrm merged commit ad0a0eb into python-control:master Jan 15, 2021
@murrayrm murrayrm added this to the 0.9.0 milestone Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnavigator bnavigator bnavigator left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

modal canonical form does not work with repeated eigenvalues
4 participants
@roryyorke @coveralls @murrayrm @bnavigator