Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't install toplevel benchmarks package #585

Merged
merged 1 commit into from Mar 21, 2021

Conversation

bnavigator
Copy link
Contributor

python setup.py install and pip install control install the benchmarks module into the toplevel sitelib. This is bad practice, because it could conflict with other packages doing the same.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.221% when pulling 4a8cd58 on bnavigator:setup-py-package into d25ef12 on python-control:master.

@murrayrm
Copy link
Member

Good catch.

@murrayrm murrayrm merged commit 203cae8 into python-control:master Mar 21, 2021
@murrayrm murrayrm added this to the 0.9.1 milestone Dec 30, 2021
@bnavigator bnavigator deleted the setup-py-package branch February 18, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants