Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lti squeeze: ndarray.ndim == 0 is also a scalar #595

Merged
merged 3 commits into from Apr 1, 2021

Conversation

bnavigator
Copy link
Contributor

Fixes #594

@coveralls
Copy link

coveralls commented Mar 28, 2021

Coverage Status

Coverage remained the same at 89.274% when pulling 5646146 on bnavigator:fix-594 into 8b900ca on python-control:master.

@bnavigator bnavigator closed this Mar 28, 2021
@bnavigator bnavigator reopened this Mar 28, 2021
@bnavigator
Copy link
Contributor Author

#594 is fixed, as one can check manually.

But I am confused that 4b44923 without f8fe08a cannot trigger a test failure.

And now I will really stop for today.

@bnavigator
Copy link
Contributor Author

Found it:

>>> np.array(0.1)
array(0.1)
>>> np.array(0.1)*1J
0.1j

@sawyerbfuller
Copy link
Contributor

Found it:

>>> np.array(0.1)
array(0.1)
>>> np.array(0.1)*1J
0.1j

What is going on here? does np.array(0.1)*1 also return a scalar instead of an array?

@bnavigator
Copy link
Contributor Author

I guess it is a somewhat less intuitive result of the broadcasting mechanics.

>>> import numpy as np
>>> a=np.array(1.0)
>>> a
array(1.)
>>> a*1J
1j
>>> a*1
1.0
>>> 1*a
1.0
>>> 1J*a
1j
>>> a+1
2.0
>>> type(a)
<class 'numpy.ndarray'>
>>> type(1*a)
<class 'numpy.float64'>
>>> type(a*1J)
<class 'numpy.complex128'>

https://numpy.org/doc/stable/reference/arrays.scalars.html

@bnavigator bnavigator merged commit de87cc6 into python-control:master Apr 1, 2021
@murrayrm murrayrm added this to the 0.9.1 milestone Dec 30, 2021
@bnavigator bnavigator deleted the fix-594 branch February 18, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

squeeze: return shape of the frequency response.
4 participants