Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various docstring edits + fixed plot legends on cruise control example #643

Merged
merged 7 commits into from Aug 7, 2021
Merged

Conversation

billtubbs
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jul 31, 2021

Coverage Status

Coverage remained the same at 89.923% when pulling cc97f4b on basicmachines:master into da27d35 on python-control:master.

@billtubbs
Copy link
Contributor Author

Oh. I just noticed there's a jupyter notebook version of the cruise control example. I'll have to update that too.

@billtubbs
Copy link
Contributor Author

billtubbs commented Aug 1, 2021

Okay, there's something I don't understand about editing a jupyter notebook. After I make the edits and run the notebook locally, the setup.py test is failing (see test results below):

File "/usr/share/miniconda/lib/python3.9/site-packages/jupyter_client/kernelspec.py", line 230, in get_kernel_spec
    raise NoSuchKernel(kernel_name)
jupyter_client.kernelspec.NoSuchKernel: No such kernel named conda-env-control-dev-py

"language": "python",
"name": "python3"
"name": "conda-env-control-dev-py"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work in the test environment.

@murrayrm
Copy link
Member

murrayrm commented Aug 1, 2021

The problem with Jupyter notebooks is that they inherit information from your local machine. So the problem is probably something like conda-env-control-dev-py is a local environment on your machine but it doesn't exist in the test environment. I marked this line in the code so that you can see where it occurs.

One fix is to edit the Jupyter notebook directly (in a text editor) and change the code you want to fix. Then commit that change and test it locally, throwing out the new version of the notebook that will be created when you run it (but still making sure it works). Push that up to GitHub and it should be OK. One caveat is that this will leave the notebook with the old figures, which may not be what you want.

Alternatively, run the notebook on your local machine and get things working, then go in and manually change the line that said conda-env-control-dev-py to say python3.

@murrayrm murrayrm merged commit 6b7a9c7 into python-control:master Aug 7, 2021
@murrayrm murrayrm added this to the 0.9.1 milestone Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants