return frequency response for 0 and 1-state systems directly #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried to debug in the failure of #659, now also occuring in #662, with some debug statements in #660, but could not reliably trigger the miscalculation (compare the GHA jobs here and in the corresponding branch of the forked repo) . I suspect a broken conda environment with Py3.9/Numpy/MKL on GHA. |
|
Ah, not compatible with |
|
Are you happy enough to merge this? Then I can check if it fixes the problem in #662 |
|
Still broken for systems with more states. :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the recent CI failures in the Slycot-less branch of the
StateSpace.horner()function. Let's try to minimize this by catching simple systems early.