Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc remove linear io system #922

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

KybernetikJo
Copy link
Contributor

  • Replace LinearIOSystem with StateSpace and LinearICSystem in docstrings
  • Reruns jupyter notebooks

I have a question:
When a PR is merged, the sphinx help is built, but jupyter notebooks are not executed again? Is that right?

I am not sure if the second commit (Rerun jupyter ....) is really necessary.

@coveralls
Copy link

Coverage Status

coverage: 94.849%. remained the same when pulling 0810502 on KybernetikJo:doc_remove_LinearIOSystem into a8658e4 on python-control:main.

@murrayrm
Copy link
Member

@KybernetikJo I don't believe that the Jupyter notebooks are regenerated when generating Sphinx output on readthedocs. So what you did is required if you want readthedocs to show the output correctly.

@murrayrm murrayrm merged commit cf27186 into python-control:main Jul 12, 2023
14 checks passed
@murrayrm murrayrm added this to the 0.10.0 milestone Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants