Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TimeResponseData.to_pandas() to handle zero state case #958

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Fix TimeResponseData.to_pandas() to handle zero state case #958

merged 1 commit into from
Jan 10, 2024

Conversation

murrayrm
Copy link
Member

@murrayrm murrayrm commented Jan 4, 2024

Fixes issue #957.

@murrayrm murrayrm linked an issue Jan 4, 2024 that may be closed by this pull request
TimeResponseData.to_pandas() fails if there are no states in a NonlinearIOSystem #957
Closed
@coveralls
Copy link

Coverage Status

coverage: 94.991% (+0.002%) from 94.989%
when pulling 6a8779c on murrayrm:to_pandas_bug-03Jan2024
into b389b64 on python-control:main.

joaoantoniocardoso
joaoantoniocardoso approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@joaoantoniocardoso joaoantoniocardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested here, thanks! :)

@bnavigator
Copy link
Contributor

LGTM

@bnavigator bnavigator merged commit 6ed2e77 into python-control:main Jan 10, 2024
14 checks passed
@murrayrm murrayrm added this to the 0.10.0 milestone Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaoantoniocardoso joaoantoniocardoso joaoantoniocardoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.

TimeResponseData.to_pandas() fails if there are no states in a NonlinearIOSystem
4 participants
@murrayrm @coveralls @bnavigator @joaoantoniocardoso