statsd: use pystatsd pipeline to send batches #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the pipeline feature has been introduced in https://github.com/jsocol/pystatsd since version 2.0
| @@ -135,6 +135,8 @@ def _send(self): | |||
| statsd.Counter(prefix, self.connection).increment( | |||
| name, value) | |||
|
|
|||
| if hasattr(statsd, 'StatsClient'): | |||
There was a problem hiding this comment.
What is the purpose of this check?
There was a problem hiding this comment.
conditional to support both python-statsd and statsd, see also other comment
jaingaurav
added a commit
that referenced
this pull request
Nov 27, 2015
statsd: use pystatsd pipeline to send batches
|
Thanks for the clarification. Perhaps in a future diamond version we can deprecate support for the older library |
|
yup, I can followup with PRs to change python-statsd with statsd in tox/travis/etc |
wmfgerrit
pushed a commit
to wikimedia/operations-puppet
that referenced
this pull request
Nov 30, 2015
use 'batch' argument to StatsdHandler to send multiple metrics per UDP packet, see also python-diamond/Diamond#327 which will be shipped in our internal diamond debian package Bug: T116033 Change-Id: I9730cd2ff364f638377be42aa681ce4c32ba9efe
wmfgerrit
pushed a commit
to wikimedia/operations-puppet
that referenced
this pull request
Dec 2, 2015
use 'batch' argument to StatsdHandler to send multiple metrics per UDP packet, see also python-diamond/Diamond#327 which will be shipped in our internal diamond debian package Bug: T116033 Change-Id: I12e61f1f69102580301dd4c791029432c5e763b9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the pipeline feature has been introduced in https://github.com/jsocol/pystatsd
since version 2.0