Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change !subscribe to Buttons for sub-roles #1866

Closed
janine9vn opened this issue Oct 10, 2021 · 4 comments
Closed

Change !subscribe to Buttons for sub-roles #1866

janine9vn opened this issue Oct 10, 2021 · 4 comments
Assignees
Labels
a: information Related to information commands: (doc, help, information, reddit, site, tags) s: planning Discussing details t: enhancement Changes or improvements to existing features

Comments

@janine9vn
Copy link
Contributor

This is coming from python-discord/meta#150.

Context

For recurring events where users might want to be notified about happenings, I'd like to add roles where we can ping people about information. The most notable application here is for PyWeek! Considering this functionality is very similar to the !subscribe command, we've determined the best UX would be to utilize the Discord Button Components and change how the !subscribe command works.

Details

This should have a button for each type of role subscription (e.g. Announcements, PyWeek). Each button will act as a toggle to either subscribe or unsubscribe from the role. This should be made clear from the text and button appearance.

Concerns

Currently, I'm only proposing this functionality for roles that we manually ping for information. It was brought up that this could be used for some of Sir Lancebot's features like Advent of Code. But that brings in additional complexities of the interplay between Python and Sir Lancebot. I'll defer to Core Devs on the approach for this.

Implementation of this feature is blocked until #1815 is merged.

@janine9vn janine9vn added s: planning Discussing details a: information Related to information commands: (doc, help, information, reddit, site, tags) t: enhancement Changes or improvements to existing features labels Oct 10, 2021
@ChrisLovering
Copy link
Member

I'd like to add to this that the implementation should be extendable. IE adding a new role would just be the case of adding an ID to a list.

@ChrisLovering
Copy link
Member

Since no one has expressed interest directly for two days, I'm going to pick this one up myself, since I quite want to do it :D

@onerandomusername
Copy link
Contributor

Was this implemented with #1868?

@ChrisLovering
Copy link
Member

Yup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: information Related to information commands: (doc, help, information, reddit, site, tags) s: planning Discussing details t: enhancement Changes or improvements to existing features
Projects
None yet
Development

No branches or pull requests

3 participants