Subscribe with buttons#1868
Merged
Merged
Conversation
onerandomusername
suggested changes
Oct 12, 2021
Xithrius
added
a: backend
ChrisLovering
force-pushed
the
subscribe-with-buttons
branch
from
cce4ba7 to
09071ad
Compare
ChrisLovering
force-pushed
the
subscribe-with-buttons
branch
from
09071ad to
c36cb9d
Compare
onerandomusername
suggested changes
Oct 12, 2021
Contributor
|
I have more changes, but github doesn't let you finish a review if the diff is changed while reviewing it... |
onerandomusername
suggested changes
Oct 12, 2021
ChrisLovering
force-pushed
the
subscribe-with-buttons
branch
2 times, most recently
from
294a008 to
6aa2121
Compare
ChrisLovering
added
s: needs review
ChrisLovering
commented
Oct 12, 2021
ChrisLovering
force-pushed
the
subscribe-with-buttons
branch
3 times, most recently
from
1aa2b12 to
70d055a
Compare
Member
Author
|
Rebased onto d.py 2.0 branch again since there were changes |
ChrisLovering
force-pushed
the
subscribe-with-buttons
branch
from
70d055a to
8b327b3
Compare
ChrisLovering
requested review from
Akarys42,
Den4200,
jb3 and
ks129
as code owners
Member
Author
|
This has fixup commits, so please do not update this branch when it's approved. Doing so would stop me from being able to rebase and actually fix them up. Just ping me when it's ready and I'll rebase properly. |
ChrisLovering
added
the
review: do not merge
This command gives the users a set of buttons to click to add or remove pre-determined announcement roles. Adding or removing a role updates the button state to reflect the change and what would happen if the user clicks the button again.
ChrisLovering
force-pushed
the
subscribe-with-buttons
branch
from
50f9404 to
176ceb9
Compare
ChrisLovering
removed
the
review: do not merge
This includes a refactor to use a dataclass for clearer implementation. Along with that, this changes the roles so that they're always available, but un-assignable roles are in red and give a different error.
ChrisLovering
force-pushed
the
subscribe-with-buttons
branch
from
176ceb9 to
19eef3e
Compare
ChrisLovering
force-pushed
the
subscribe-with-buttons
branch
from
d36467b to
aecb093
Compare
janine9vn
approved these changes
Nov 30, 2021
Contributor
janine9vn
left a comment
janine9vn
left a comment
There was a problem hiding this comment.
You addressed all my previous concerns in #dev-contrib. Great feature and very nice code, thank you!
Bluenix2
approved these changes
Dec 1, 2021
Contributor
Bluenix2
left a comment
Bluenix2
left a comment
There was a problem hiding this comment.
Nice addition and QoL change - thanks Chris this looks good!
Akarys42
approved these changes
Dec 1, 2021
4 tasks
Xithrius
removed
the
s: needs review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the subscribe command to be interactive with discord buttons.
Running this command now gives the users a set of buttons to click to add or remove pre-determined announcement roles.
Adding or removing a role updates the button state to reflect the change and what would happen if the user clicks the button again.
Screenshot(s)
This is what the command looks like after I ran it with no roles, then added the PyWeek role to myself.
