Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!doc for stdlib items gives 2to3 results #210

Closed
lemonsaurus opened this issue Nov 29, 2018 · 1 comment · Fixed by #546
Closed

!doc for stdlib items gives 2to3 results #210

lemonsaurus opened this issue Nov 29, 2018 · 1 comment · Fixed by #546
Labels
t: bug Something isn't working

Comments

@lemonsaurus
Copy link
Member

For some reason, calling !doc get dict or !doc get filter will fetch the docs from 2to3 rather than displaying the docs for the built-ins.

@lemonsaurus lemonsaurus changed the title !doc for stdlib items gives 2to3 results !doc for stdlib items gives 2to3 results Nov 29, 2018
@jchristgit
Copy link
Member

That is a thing I've spotted for a while but wasn't sure with how to fix it. I believe we should be able to add an exclusion list to the inventory fetching, but that will be very expensive due to the number of symbols involved. Relevant code snippet:

        fetch_func = functools.partial(intersphinx.fetch_inventory, config, '', inventory_url)
        for _, value in (await self.bot.loop.run_in_executor(None, fetch_func)).items():
            # Each value has a bunch of information in the form
            # `(package_name, version, relative_url, ???)`, and we only
            # need the relative documentation URL.
            for symbol, (_, _, relative_doc_url, _) in value.items():
                absolute_doc_url = base_url + relative_doc_url
                self.inventories[symbol] = absolute_doc_url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants