New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs command improvements #546
Conversation
any reason Lines 210 to 219 in f194df8
|
Needs some further testing and going to take a look if I can implement #381 here |
@jchristgit any reason 7d2b784 uses |
Some issues that I'm aware of but don't know if they should be looked into further:
Also not sure if the handling and logging of exceptions when fetching inventories is correct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A number of symbols have reduced usefulness after the changes. For example, list
and multiprocess.Process
both show the following:
This appears to be a generic page not tied to a specific symbol.
I feel like this still needs some work in order to improve consistency expected behaviour, as these cases actually had decent information output in the current version.
Another thing is I'd like to see a command added that will call refresh_inventory
. If we add a new entry to the site, this ensures we can reload it without doing an internal eval.
Co-authored-by: scargly <29337040+scragly@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more bracket styling to fix (same as the previous ones but you added this one while removing the others). And adding back in some lost info after a comment was taken out.
Co-authored-by: scargly <29337040+scragly@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now, thanks for your work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Improves the docs command by:
closes: #538
closes: #210
closes: #381