Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charinfo doesn't escape backticks #996

Closed
MarkKoz opened this issue Jun 12, 2020 · 0 comments · Fixed by #997
Closed

Charinfo doesn't escape backticks #996

MarkKoz opened this issue Jun 12, 2020 · 0 comments · Fixed by #997
Assignees
@MarkKoz
Labels
a: frontend Related to output and formatting good first issue Good for newcomers p: 3 - low Low Priority t: bug Something isn't working

Comments

@MarkKoz
Copy link
Member

MarkKoz commented Jun 12, 2020

The Unicode escapes are formatted in code blocks. When the embed tries to also render a literal backtick, this ends up interfering with the code blocks and creating a mess.

bild
@MarkKoz MarkKoz added t: bug Something isn't working good first issue Good for newcomers a: frontend Related to output and formatting p: 3 - low Low Priority labels Jun 12, 2020
@MarkKoz MarkKoz self-assigned this Jun 12, 2020
MarkKoz added a commit that referenced this issue Jun 12, 2020
@MarkKoz
Escape markdown in charinfo embed
46e770b 
The embed displays the original character. If it's a markdown char,
it would interfere with the embed's actual markdown. The backtick was
especially troublesome.

Fixes #996
@MarkKoz MarkKoz mentioned this issue Jun 12, 2020
Merged
@jb3 jb3 closed this as completed in #997 Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarkKoz MarkKoz

Labels
a: frontend Related to output and formatting good first issue Good for newcomers p: 3 - low Low Priority t: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Escape markdown in charinfo embed python-discord/bot
1 participant
@MarkKoz