Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mod log event for member warn & shadowwarn #233

Merged
merged 1 commit into from
Dec 30, 2018
Merged

Add mod log event for member warn & shadowwarn #233

merged 1 commit into from
Dec 30, 2018

Conversation

sco1
Copy link
Contributor

@sco1 sco1 commented Dec 29, 2018

See #137

scragly
scragly approved these changes Dec 29, 2018
View reviewed changes
Copy link
Contributor

@scragly scragly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward and works.
Should the icon be named after it's usage in this case or the original emoji name of modlogmessage though?
Only a passing remark though, I'd be happy to have this merged as-is.

@jchristgit
Copy link
Member

I think the icon name is fine. We can revisit it later if we're unhappy with it.

@jchristgit jchristgit merged commit 2d1e5e2 into master Dec 30, 2018
@jchristgit jchristgit deleted the warn-modlog branch December 30, 2018 12:58
@jchristgit jchristgit mentioned this pull request Dec 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchristgit jchristgit jchristgit approved these changes

@scragly scragly scragly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sco1 @jchristgit @scragly