Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use new markdown feature in new help channel message #2726

Merged
merged 11 commits into from Nov 25, 2023
Merged

feat: use new markdown feature in new help channel message #2726

merged 11 commits into from Nov 25, 2023

Conversation

DownDev
Copy link
Contributor

@DownDev DownDev commented Aug 21, 2023

Closes #2646

@ChrisLovering
Copy link
Member

Does this PR cover everything required in that issue? If not, we shouldn't mark this PR as closing that issue.

@DownDev
Copy link
Contributor Author

DownDev commented Aug 23, 2023

I guess i can go over commands and see if there is something to change.

@DownDev DownDev marked this pull request as draft August 23, 2023 13:56
@ChrisLovering
Copy link
Member

I guess i can go over commands and see if there is something to change.

We can also just review & merge this PR, but not have it marked as closing the issue. With further changes in other PRs. It's up to you.

@DownDev

This comment was marked as outdated.

Sign in to view
@DownDev
Copy link
Contributor Author

DownDev commented Aug 23, 2023

@ChrisLovering Actually many tags dont use correct syntax for markdown. Also the !patreon supporters command is what i found for now.

All of the above are using the • instead of -

@DownDev DownDev marked this pull request as ready for review August 24, 2023 21:24
@wookie184 wookie184 added the s: needs review Author is waiting for someone to review and approve label Aug 31, 2023
Xithrius
Xithrius approved these changes Sep 23, 2023
View reviewed changes
Copy link
Member

@Xithrius Xithrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Might want to look around again after this branch is updated.

@ChrisLovering ChrisLovering merged commit d4fdbce into python-discord:main Nov 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisLovering ChrisLovering ChrisLovering approved these changes

@Xithrius Xithrius Xithrius approved these changes

@wookie184 wookie184 Awaiting requested review from wookie184 wookie184 is a code owner

@ks129 ks129 Awaiting requested review from ks129

@mbaruh mbaruh Awaiting requested review from mbaruh mbaruh is a code owner

@Den4200 Den4200 Awaiting requested review from Den4200

@jb3 jb3 Awaiting requested review from jb3

Assignees
No one assigned
Labels
s: needs review Author is waiting for someone to review and approve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use new markdown features in messages
4 participants
@DownDev @ChrisLovering @Xithrius @wookie184