Superstarify cleanup as per issue #288 , no changes to the command. #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ces/stars.json, all stars are stored in a name: url key-value pair. No changes to the starify command has been made. This commit simply adds the filtered json file
jb3
approved these changes
Feb 4, 2019
sco1
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to simplify process of issue #288
This PR simply adds the stars.json file to bot/resources. This json file contains all the previous artists in a name: image url pair. Bands have been filtered out with some of the artists in said bands being added. All images are fetched from their profile pictures on wikipedia with the exception of Enya, she did not have one...
This PR does not change the command in any way, it simply adds the json for when we want to start using it on the bot side instead of from site