Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds dockerfile that uses pipenv #60

Merged
merged 10 commits into from
Apr 28, 2018
Merged

adds dockerfile that uses pipenv #60

merged 10 commits into from
Apr 28, 2018

Conversation

Inveracity
Copy link
Contributor

@Inveracity Inveracity commented Apr 27, 2018 •
edited 

docker build -t pythondiscord/bot .

jchristgit
jchristgit reviewed Apr 27, 2018
View reviewed changes
Dockerfile Outdated

COPY . /

RUN pipenv sync
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make sense to use --bare for minimal output here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer having a lot of output instead, makes it easier to debug in case of a bad build

@Inveracity Inveracity merged commit 54369f6 into master Apr 28, 2018
@Inveracity Inveracity deleted the dockerfile branch April 28, 2018 12:28
Ultros-Bot pushed a commit that referenced this pull request Aug 30, 2018
@gdude2002
[Security] Prevent commands in DM - Fixes #60
1de1e8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchristgit jchristgit jchristgit left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Inveracity @jchristgit