Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling for empty PEP metadata values #721

Merged
merged 1 commit into from Jan 12, 2020
Merged

Conversation

@sco1
Copy link
Member

sco1 commented Jan 11, 2020

Some PEPs have a metadata field that is present but has an empty value (e.g. PEP 249), causing an exception to be raised when attempting to add it as an embed field value, which cannot be empty.

This refactors the information parsing to prevent the field from being added if there is no value to provide, as well as cut down on copy+paste when populating fields in the embed.

Closes #720

Some PEPs have a metadata field that is present but has an empty value (e.g. PEP 249), causing an exception to be raised when attempting to add it as an embed field value, which cannot be empty.

This refactors the information parsing to prevent the field from being added if there is no value to provide, as well as cut down on copy+paste when populating fields in the embed.
@jchristgit jchristgit self-assigned this Jan 12, 2020
@jchristgit jchristgit merged commit a0e5eae into master Jan 12, 2020
2 checks passed
2 checks passed
Bot Build #20200111.2 succeeded
Details
Bot (Lint & Test) Lint & Test succeeded
Details
@jchristgit jchristgit deleted the pep-empty-field-fix branch Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.