Add the snake quiz from Team 7 - Mushy and Cardium - to the snakes cog. #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good PR. The code is in working order and does what it should do. I'm gonna merge this and then make some changes - I think we should have the JSON data in our database and there are some other minor issues here but they're with the original code design and not with your PR. |
lemonsaurus
approved these changes
May 10, 2018
jb3
pushed a commit
that referenced
this pull request
May 19, 2018
* Added the random_snake_name feature, created by Iceman * Added Antidote to the snake_cog. * Add the snake quiz from Team 7 - Mushy and Cardium - to the snakes cog. (#74) Original PR: python-discord/code-jam-1#2 Completes task: https://app.clickup.com/754996/757069/t/2ww7u * Cleaned up the snake quiz * Cleaning up snake_quiz further and integrating it towards the new API for snake questions. * Bugfixes for Antidote and Quiz * Implemented the zzzen of pythhhon, by prithaj and andrew. * Added the snake facts feature by Andrew and Prithaj. Also cleaned up some code smell. * Implemented the snake_videos feature. Also made a fix for a bug with https sessions on local aiohttp * Implemented Momo and kel's snake perlin noise gen draw feature * Implemented the hatch feature from Momo and Kels PR * Implemented the snakemefeature from the momo and kel PR, with big modifications. It no longer uses markov, it was just too slow to get it to do something interesting. It can also be passed a message to snakify that instead. * Started on Snakes and Ladders, but want to refactor it to use reactions. Fixed up the perlin noise gen to generate random snake attributes. * Movie command, initial version * Snakes and Ladders implemented and rewritten to use reactions for controls. * made the snek draw feature even more fabulous. * SAL, get_snek, perlin * Fixing some minor problems with startup log spam. The bot will now only try to post to DEVLOG if it's not in debug mode. Also added the new snake API endpoints and prepping for database handling of all snek related datapoints. * Pointed all relevant functions at their respective snake API endpoints. Tested. All the data is now in our database, and everything appears to work. * Added the guessing game by Ava and eivl * Trailing comma, baby * Added snake cards. * Added the snakes.about command, and cleaned up the cog. Still got a couple of bugs with snake_card, but other than that this is done. * Some fixes for the snake cards. Cards now use the converter on the snake input, so it can disambiguate just like .get. Also made the special cases like bob ross available to both .get and .card * Some fixes to address Volcyy's review. * Addressing comments by gdude on the site PR * Changes requested by Joseph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: python-discord/code-jam-1#2
Completes task: https://app.clickup.com/754996/757069/t/2ww7u