Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contributor doc #180

Merged
merged 2 commits into from
Apr 3, 2019
Merged

Update contributor doc #180

merged 2 commits into from
Apr 3, 2019

Conversation

sco1
Copy link
Contributor

@sco1 sco1 commented Apr 2, 2019

@sco1
Update contributor doc
ce25477 
Remove April Fools lemon counter
@scragly scragly added the area: docs Adds or updates documentation label Apr 3, 2019
@jodth07
Copy link
Contributor

jodth07 commented Apr 3, 2019

I made some minor lexical changes, such as removing event handlers, as they are also staff.

@jodth07
Copy link
Contributor

jodth07 commented Apr 3, 2019

this looks good.

SebastiaanZ
SebastiaanZ approved these changes Apr 3, 2019
View reviewed changes
Copy link
Member

@SebastiaanZ SebastiaanZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks excellent to me and we should merge this soon, if possible.

@scragly scragly merged commit 268292f into master Apr 3, 2019
@scragly scragly deleted the contrib-update branch April 3, 2019 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scragly scragly scragly approved these changes

@SebastiaanZ SebastiaanZ SebastiaanZ approved these changes

Assignees
No one assigned
Labels
area: docs Adds or updates documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sco1 @jodth07 @scragly @SebastiaanZ