Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show previous conversation prompts after .topic command is reacted to #1145

Open
2 tasks done
Anonymous4045 opened this issue Nov 13, 2022 · 0 comments · May be fixed by #1148
Open
2 tasks done

Show previous conversation prompts after .topic command is reacted to #1145

Anonymous4045 opened this issue Nov 13, 2022 · 0 comments · May be fixed by #1148
Assignees
@Anonymous4045
Labels
status: approved The issue has received a core developer's approval type: feature Relating to the functionality of the application.

Comments

@Anonymous4045
Copy link

Anonymous4045 commented Nov 13, 2022 •
edited
Loading

Description

After a member invokes the "topic" command, they have the ability to re-roll the embed to choose a different conversation prompt. When they do this, the previous contents of the message is overwritten. Instead, the content should be edited to include the new prompt with the old prompt(s) above it, with a number corresponding to the order it was created in.

Reasoning

When the person who invokes the command sees a topic they don't want to comment on, they tend to re-roll it by reacting to the message. However, other people in the chat may see it and have something to say, but the message is edited before they can respond. If the change I proposed is added, this person could just put the number of that prompt at the start of his or her message.

Proposed Implementation

Current System
Bot message:
"What is your favorite PyPI module?"

invoker reacts to re-roll

New bot message:
"How has Python changed your life?"

Proposed Change
Bot message:
"What is your favorite PyPI module?"

invoker reacts to re-roll

New bot message:
"1. What is your favorite PyPI module?
2. How has Python changed your life?"

Would you like to implement this yourself?

  • I'd like to implement this feature myself
  • Anyone can implement this feature
@Anonymous4045 Anonymous4045 added status: planning Discussing details type: feature Relating to the functionality of the application. labels Nov 13, 2022
Anonymous4045 added a commit to Anonymous4045/sir-lancebot that referenced this issue Nov 15, 2022
@Anonymous4045
Add ability to view previous topics with .topic command
ecc33e0 
After a user invokes the ".topic" command and reacts with the reroll emoji, the embed will now show the previous few messages. It cannot display more than
256 characters, which is usually around 5 prompts.

Implements: python-discord#1145
@Anonymous4045 Anonymous4045 linked a pull request Nov 15, 2022 that will close this issue
Open
4 tasks
@Xithrius Xithrius added status: approved The issue has received a core developer's approval and removed status: planning Discussing details labels Nov 16, 2022
Ibrahim2750mi pushed a commit to Ibrahim2750mi/sir-lancebot that referenced this issue Feb 25, 2023
@Anonymous4045 @Ibrahim2750mi
Add ability to view previous topics with .topic command
4a2b741 
After a user invokes the ".topic" command and reacts with the reroll emoji, the embed will now show the previous few messages. It cannot display more than
256 characters, which is usually around 5 prompts.

Implements: python-discord#1145
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Anonymous4045 Anonymous4045

Labels
status: approved The issue has received a core developer's approval type: feature Relating to the functionality of the application.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ability to view previous topics with .topic command Anonymous4045/sir-lancebot
2 participants
@Xithrius @Anonymous4045