Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ruff from 0.3.7 to 0.4.4 #1527

Closed
wants to merge 2 commits into from
Closed

Bump ruff from 0.3.7 to 0.4.4 #1527

wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 10, 2024 •
edited

Bumps ruff from 0.3.7 to 0.4.4.

Release notes

Sourced from ruff's releases.

v0.4.4

Changes

Preview features

  • [pycodestyle] Ignore end-of-line comments when determining blank line rules (#11342)
  • [pylint] Detect pathlib.Path.open calls in unspecified-encoding (PLW1514) (#11288)
  • [flake8-pyi] Implement PYI059 (generic-not-last-base-class) (#11233)
  • [flake8-pyi] Implement PYI062 (duplicate-literal-member) (#11269)

Rule changes

  • [flake8-boolean-trap] Allow passing booleans as positional-only arguments in code such as set(True) (#11287)
  • [flake8-bugbear] Ignore enum classes in cached-instance-method (B019) (#11312)

Server

  • Expand tildes when resolving Ruff server configuration file (#11283)
  • Fix ruff server hanging after Neovim closes (#11291)
  • Editor settings are used by default if no file-based configuration exists (#11266)

Bug fixes

  • [pylint] Consider with statements for too-many-branches (PLR0912) (#11321)
  • [flake8-blind-except, tryceratops] Respect logged and re-raised expressions in nested statements (BLE001, TRY201) (#11301)
  • Recognise assignments such as __all__ = builtins.list(["foo", "bar"]) as valid __all__ definitions (#11335)

Contributors

v0.4.3

Changes

Enhancements

  • Add support for PEP 696 syntax (#11120)

... (truncated)

Changelog

Sourced from ruff's changelog.

0.4.4

Preview features

  • [pycodestyle] Ignore end-of-line comments when determining blank line rules (#11342)
  • [pylint] Detect pathlib.Path.open calls in unspecified-encoding (PLW1514) (#11288)
  • [flake8-pyi] Implement PYI059 (generic-not-last-base-class) (#11233)
  • [flake8-pyi] Implement PYI062 (duplicate-literal-member) (#11269)

Rule changes

  • [flake8-boolean-trap] Allow passing booleans as positional-only arguments in code such as set(True) (#11287)
  • [flake8-bugbear] Ignore enum classes in cached-instance-method (B019) (#11312)

Server

  • Expand tildes when resolving Ruff server configuration file (#11283)
  • Fix ruff server hanging after Neovim closes (#11291)
  • Editor settings are used by default if no file-based configuration exists (#11266)

Bug fixes

  • [pylint] Consider with statements for too-many-branches (PLR0912) (#11321)
  • [flake8-blind-except, tryceratops] Respect logged and re-raised expressions in nested statements (BLE001, TRY201) (#11301)
  • Recognise assignments such as __all__ = builtins.list(["foo", "bar"]) as valid __all__ definitions (#11335)

0.4.3

Enhancements

  • Add support for PEP 696 syntax (#11120)

Preview features

  • [refurb] Use function range for reimplemented-operator diagnostics (#11271)
  • [refurb] Ignore methods in reimplemented-operator (FURB118) (#11270)
  • [refurb] Implement fstring-number-format (FURB116) (#10921)
  • [ruff] Implement redirected-noqa (RUF101) (#11052)
  • [pyflakes] Distinguish between first-party and third-party imports for fix suggestions (#11168)

Rule changes

  • [flake8-bugbear] Ignore non-abstract class attributes when enforcing B024 (#11210)
  • [flake8-logging] Include inline instantiations when detecting loggers (#11154)
  • [pylint] Also emit PLR0206 for properties with variadic parameters (#11200)
  • [ruff] Detect duplicate codes as part of unused-noqa (RUF100) (#10850)

Formatter

  • Avoid multiline expression if format specifier is present (#11123)

... (truncated)

Commits
  • 3e8878a Bump version to v0.4.4 (#11352)
  • b6b4ad9 [red-knot] @​override lint rule (#11282)
  • dd42961 [pylint] Detect pathlib.Path.open calls in unspecified-encoding (`PLW15...
  • c80c171 [red-knot] Vendor typeshed's stdlib (#11340)
  • e2fe177 Revert "Simplify arithmetic operation in logical lines checker (#11346)" (#11...
  • e9d1cdd Simplify arithmetic operation in logical lines checker (#11346)
  • dfe4291 Improve ruff_python_semantic::all::extract_all_names() (#11335)
  • 4541337 [red-knot] Remove \<Db: SemanticDb> contraints in favor of dynamic dispatch ...
  • 8e9ddee Ignore end-of-line comments when determining blank line rules (#11342)
  • 702d2fa Make B024 and B027 documentation more nuanced (#11341)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added area: dependencies Related to package dependencies and management python Pull requests that update Python code labels May 10, 2024
@dependabot dependabot bot mentioned this pull request May 10, 2024
Closed
@dependabot dependabot bot force-pushed the dependabot/pip/ruff-0.4.4 branch 4 times, most recently from 556a10c to 1b1c410 Compare May 20, 2024 15:44
@Xithrius
Copy link
Member

Thoughts on ignoring rule RUF029?

@dependabot
Bump ruff from 0.3.7 to 0.4.4
07f958e 
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.3.7 to 0.4.4.
- [Release notes](https://github.com/astral-sh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ruff@v0.3.7...v0.4.4)

---
updated-dependencies:
- dependency-name: ruff
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/pip/ruff-0.4.4 branch from 1b1c410 to 07f958e Compare May 21, 2024 02:13
@wookie184
Copy link
Contributor

Thoughts on ignoring rule RUF029?

Sounds sensible to me, it seems fairly prone to false positives, and having something async when it doesn't need to be isn't really an issue anyway.

@Xithrius
Copy link
Member

Very well. I shall make our thoughts a reality.

@Xithrius Xithrius enabled auto-merge (squash) May 21, 2024 02:31
wookie184
wookie184 approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github May 23, 2024

A newer version of ruff exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@wookie184
Copy link
Contributor

I probably should have waited on merging other dependabot PRs to avoid making a conflict here... my bad.

Could you fix pls Xith (and could someone else approve too so it can be merged without more conflicts)

@Xithrius
Copy link
Member

imma just have dependabot make another PR since there's a new version as well

@Xithrius Xithrius closed this May 23, 2024
auto-merge was automatically disabled May 23, 2024 21:28

Pull request was closed

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github May 23, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@Xithrius Xithrius deleted the dependabot/pip/ruff-0.4.4 branch May 23, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wookie184 wookie184 wookie184 approved these changes

Assignees
No one assigned
Labels
area: dependencies Related to package dependencies and management python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Xithrius @wookie184