Nasa commands #363
Nasa commands #363
Conversation
| from bot.constants import Colours, ERROR_REPLIES | ||
|
|
||
| log = logging.getLogger(__name__) | ||
| api_key = os.environ['NASA_API'] |
There was a problem hiding this comment.
Should be moved to constants.py (under Tokens).
| api_key = os.environ['NASA_API'] | ||
|
|
||
|
|
||
| async def fetch(session: aiohttp.ClientSession, url: str) -> str: |
| async def fetch(session: aiohttp.ClientSession, url: str) -> str: | ||
| """Helps to get JSON from an API.""" | ||
| async with session.get(url) as response: | ||
| return await response.text() |
There was a problem hiding this comment.
Use await response.json() to instantly return Dictionary.
| class Space(commands.Cog): | ||
| """A cog to get some amazing looking space pictures using NASA API.""" | ||
|
|
||
| def __init__(self, client: commands.bot): |
There was a problem hiding this comment.
First, it's commands.Bot and rename client to bot.
| @commands.command(description='Astronomy Picture of the Day') | ||
| async def apod(self, ctx: commands.context) -> None: | ||
| """Get a cool looking picture from NASA along it's description. That changes every day.""" | ||
| async with aiohttp.ClientSession() as session: |
There was a problem hiding this comment.
It's better to use self.bot.http_session instead of making new one
| async def mars(self, ctx: commands.context) -> None: | ||
| """Get a random picture from Mars using NASA's API.""" | ||
| log.info(f'{ctx.author} used mars command.') | ||
| async with aiohttp.ClientSession() as session: |
| log.info(f'{ctx.author} used mars command.') | ||
| async with aiohttp.ClientSession() as session: | ||
| url = f'https://api.nasa.gov/mars-photos/api/v1/rovers/Curiosity/photos?sol=1000&api_key={api_key}' | ||
| response = requests.get(url) # Only Curiosity have Curious pictures. |
There was a problem hiding this comment.
Don't use blocking requests library.
| if int(headers['X-RateLimit-Remaining']) <= 1: | ||
| embed = discord.Embed( | ||
| title=random.choice(ERROR_REPLIES), | ||
| description='API request limit reached for now. Maybe you can try again after some time ?', |
| await ctx.send(embed=embed) | ||
| return | ||
|
|
||
| html = await fetch(session, url) |
| return | ||
|
|
||
| html = await fetch(session, url) | ||
| data = json.loads(html) |
|
In the pull request template, we have asked you whether you have remembered to:
You said yes to both of these, in spite of the fact that you obviously did not do either of them. You have also added a dependency, On top of that, your commits are of poor quality, are not atomic, and have poor commit messages like The commit that adds When these things were commented on in #dev-contrib, your response was frustration and vitriol. You requested my review, so here it is: If you're intent on disregarding our advice and making these poor quality pull requests again and again, maybe it's best if you stop contributing to us. I'm closing this PR. |
Relevant Issues
Closes #357
Closes #358
Closes #359
Closes #360
Gonna only use pictures from curiosity as only that have some interesting pictures.
Additional Details
Note:-
It needs an API key generated from https://api.nasa.gov/
and stored in env variable named
NASA_APIpipenv lock?pipenv run lint)?