Space Cog implementing

[ks129]

Relevant Issues

Closes #360
Closes #359
Closes #358
Closes #357

Description

I added .apod <date (optional)>, .nasa, .mars <date> and .earth command. Note: Mars command have date limitations.

Reasoning

Due their issues got approved.

Screenshots

Did you:

• Join the Python Discord Community?
• If dependencies have been added or updated, run pipenv lock?
• Lint your code (pipenv run lint)?
• Set the PR to allow edits from contributors?

[SurajBhari]

Where are the embed colors ?
they look like washed away

[ks129]

@AG4lyf Embed colors is not most important things...

[SebastiaanZ]

As a general question, I noticed that we're only using the image urls we get back from the API; do the API responses also include image data? And, if so, do you have an idea about the size of these responses? Are we talking KBs? MB? Multiple MB per request?

[ks129]

@SebastiaanZ First, .nasa command always have at least 50 pages (I think they might have thousands pages). And all responses is in KBs. Some commands is just slow due API latency or image size. Images is always URLs, never anything else.

[sco1]

As stated in the issues this PR covers, these should all be implemented as subcommands of a single command, rather than as individual commands.

As also stated in the issues this PR covers, there should be some more customization available for the commands to make queries more interesting.

For example:

• The NASA Image API supports quite a few search options, including a free text search, keyword search, description search, and year start/end constraints
• The Earth API endpoint supports latitude & longitude queries
• The Mars command right now only fetches images from the Curiosity Rover and there are 2 other rovers (Opportunity, Spirit) supported by the API

The default being a purely random selection is fine, but please take some time to review the API documentation for each of the endpoints being used here and expand the functionality to provide the capability for some more interesting searches.

As commented on in #350, there needs to be handling for the scenario where the requested page (currently selected randomly) exceeds the number of pages present.

[sco1]

There are a few instances where multilining doesn't align with the prevailing codestyle in the repository, and also is inconsistent within the cog.

This, for example:

await ctx.send(embed=await self.create_nasa_embed(
    item["data"][0]["title"],
    item["data"][0]["description"],
    item["links"][0]["href"]
))

Should be something like this:

await ctx.send(
    embed=await self.create_nasa_embed(
        item["data"][0]["title"],
        item["data"][0]["description"],
        item["links"][0]["href"]
    )
)

Same with function signatures.

No:

async def fetch_from_nasa(self,
                          endpoint: str,
                          params: Optional[Dict[str, Any]] = None,
                          base: Optional[str] = NASA_BASE_URL
                          ) -> Dict[str, Any]:

Yes:

async def fetch_from_nasa(
    self,
    endpoint: str,
    params: Optional[Dict[str, Any]] = None,
    base: Optional[str] = NASA_BASE_URL
) -> Dict[str, Any]:

Addressed

[ikuyarihS]

Every looks pretty good! I only have some small nags, and this should be good to go.