Update Oracle matching #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems Oracle ships an /etc/os-release which has an ID of 'ol'. To make sure it returns the id "oracle" as mentioned in the docs, match this. Update the testing.
brk3
reviewed
Aug 8, 2018
| @@ -48,7 +48,9 @@ | |||
| #: with blanks translated to underscores. | |||
| #: | |||
| #: * Value: Normalized value. | |||
| NORMALIZED_OS_ID = {} | |||
| NORMALIZED_OS_ID = { | |||
| 'ol': 'oracle', # Oracle Enterprise Linux | |||
There was a problem hiding this comment.
Probably not a big deal, but officially we just refer to this as "Oracle Linux" now, the "enterprise" wording has been dropped.
nir0s
approved these changes
Sep 4, 2018
|
Hi, is there a release schedule or other plan for integrating this? Thanks |
|
@nir0s Any chance of merging this? I do not have personal intention to test the oracle blend but the fix seems genuine and I would prefer to avoid adding workarounds in openstack projects that rely on distro library. A fix here is clearly preffered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems Oracle ships an /etc/os-release which has an ID of 'ol'. To
make sure it returns the id "oracle" as mentioned in the docs, match
this. Update the testing.
I noticed this from the following change which was proposed to OpenStack's bindep : https://review.openstack.org/#/c/536355/
You can see some small testing pulling it from docker in http://paste.openstack.org/show/726682/. I confirmed I got "oracle" back there too with this small change.