catch and ignore subprocess.CalledProcessError when running lsb_relsase
#261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yphus
approved these changes
Sep 18, 2020
|
Can this be merged? |
brejoc
approved these changes
Dec 1, 2020
|
@nir0s Would be really cool if you could take a look at this PR! |
|
@nir0s I have fixed the lint issue and the tests to fit the new code, any chance this can be reviewed? |
|
@nir0s Is there a way to get this merged somehow? Is something blocking this PR? |
|
@nir0s Thanks a lot for merging this! |
|
@nir0s Thanks a lot, I have been waiting for this one. |
|
@nir0s Can you please make a new release with this fix included? |
19 tasks
yphus
added a commit
to yphus/monorepo-sandbox
that referenced
this pull request
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for #260 issue.
Ignore
lsb_releaseissues.The other solution that I have is if
lsb_releaseinstalled but the executable is broken, we can just parse/etc/lsb_releasefiles to get the same information (maybe it can replace thesubprocess.check_outputcompletely).