Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore the file '/etc/board-release' #353

Merged

Conversation

pedrolamas
Copy link
Contributor

Adds board-release to ignored patterns, which is used by some Armbian based releases, such as the one used with the BigTreeTech CB1.

Full text search here:
https://github.com/bigtreetech/CB1-Kernel/search?q=board-release

@HorlogeSkynet
Copy link
Member

Hi @pedrolamas ! Many thanks for your PR, one comment though : could you provide a "testing" rootfs under tests/resources/distros/ too ? 🙂

@pedrolamas pedrolamas force-pushed the pedrolamas/ignore-board-release branch from 2cb365c to 298d2cf Compare February 20, 2023 18:23
@pedrolamas
Copy link
Contributor Author

Thanks @HorlogeSkynet, I've now added a test for this specific case.

@HorlogeSkynet
Copy link
Member

HorlogeSkynet commented Feb 20, 2023

Thanks ! We'll have to wait for #355 and a proper rebase/merge of this branch 😉


EDIT : Ready for rebase 😇

@pedrolamas pedrolamas force-pushed the pedrolamas/ignore-board-release branch from 298d2cf to 5cdd431 Compare February 20, 2023 20:58
@pedrolamas pedrolamas force-pushed the pedrolamas/ignore-board-release branch from 5cdd431 to 45711d1 Compare February 20, 2023 21:01
@pedrolamas
Copy link
Contributor Author

pedrolamas commented Feb 20, 2023

EDIT : Ready for rebase 😇

Rebased! 😁

HorlogeSkynet
HorlogeSkynet previously approved these changes Feb 23, 2023
@HorlogeSkynet HorlogeSkynet merged commit 5fc214c into python-distro:master Mar 11, 2023
@pedrolamas pedrolamas deleted the pedrolamas/ignore-board-release branch March 12, 2023 11:11
@HorlogeSkynet HorlogeSkynet added this to the 1.8.1 milestone Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants