Test on modern versions of CPython and PyPy and macOS

[cclauss]

    strategy:
      matrix:
        python:
+         - "3.11"
+         - "3.12"
        include:
+         - os: "ubuntu-latest"
+           python: "pypy-3.10"
+         - os: "macos-latest"
+           python: 3.x

[hartwork]

Let's use explicit ubuntu-22.04 and macos-12 here please, the more pinned, the better for CI stability. Can we pin 3.x any more? Is this intended to be 3.13 pre-release?

[cclauss]

My Mac is running 14.1.1. Why do we want to pin to an OS that is two major versions behind the current macOS?

• https://www.google.com/search?client=firefox-b-d&q=current+macos

Python 3.x pins to the latest released version of CPython which will remain 3.12 until October 2024.

I like it when CI highlights when OS upgrades break the tests rather than waiting for users to complain.

[hartwork]

Hi @cclauss, thanks for the adjustments!

My Mac is running 14.1.1. Why do we want to pin to an OS that is two major versions behind the current macOS?

• https://www.google.com/search?client=firefox-b-d&q=current+macos

Because macos-latest is macos-12 is of today, see https://github.com/actions/runner-images#about . Their macos-13 is in beta and they have no 14 as of today.

I like it when CI highlights when OS upgrades break the tests rather than waiting for users to complain.

That is a great idea in its core but broken CI means that e.g. all new pull request starting before a fix will have no chance on a green CI, and I have seen broken CI that no one fixes for weeks in too many places to ever want to go into the red zone voluntarily. The approach with testing against the latest moving things only really works well when the errors are ignored but notified about. Latest time I checked, GitHub Actions doesn't allow operation like that in practice, happy to be proven wrong about that for today. The best approach I know is pinning evereything hard and let a machine produce auto-update pull requests. What Dependabot and Renovate cannot cover, you can cover yourself e.g. using https://github.com/peter-evans/create-pull-request . That was the long version, I hope that was in your interest.

Python 3.x pins to the latest released version of CPython which will remain 3.12 until October 2024.

Let's make it 3.12 then for CI stability, please.

[cclauss]

Oh... Now I see that all pytests except one are skipped on macOS and Windows...

============================= test session starts ==============================
platform darwin -- Python 3.12.0, pytest-7.4.3, pluggy-1.3.0
cachedir: .tox/py/.pytest_cache
rootdir: /Users/runner/work/distro/distro
plugins: cov-4.1.0
collected 234 items

tests/test_distro.py .ssssssssssssssssssssssssssssssssssssssssssssssssss [ 21%]
ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss [ 52%]
ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss [ 83%]
sssssssssssssssssssssssssssssssssssssss                                  [100%]

---------- coverage: platform darwin, python 3.12.0-final-0 ----------

Are macOS and Windows supported or not? Homebrew/homebrew-core#155740 @chenrui333

[nir0s]

Oh... Now I see that all pytests except one are skipped on macOS and Windows...

============================= test session starts ==============================
platform darwin -- Python 3.12.0, pytest-7.4.3, pluggy-1.3.0
cachedir: .tox/py/.pytest_cache
rootdir: /Users/runner/work/distro/distro
plugins: cov-4.1.0
collected 234 items

tests/test_distro.py .ssssssssssssssssssssssssssssssssssssssssssssssssss [ 21%]
ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss [ 52%]
ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss [ 83%]
sssssssssssssssssssssssssssssssssssssss                                  [100%]

---------- coverage: platform darwin, python 3.12.0-final-0 ----------

Are macOS and Windows supported or not? Homebrew/homebrew-core#155740 @chenrui333

Windows and OSx aren't supported in the sense that we don't identify them. It doesn't mean that distro can't run on them, we just won't identify their distributions.

There's been an open issue for this for a very long time now (#177), but, apparently, it wasn't urgent for anyone to actually finish the job. You're more than invited.

[hartwork]

@cclauss thanks for the pinning! 🙏

[chenrui333]

Windows and OSx aren't supported in the sense that we don't identify them. It doesn't mean that distro can't run on them, we just won't identify their distributions.

yeah, that is what I saw in my test as well.

this is the running result on ventura arm machine.

$ distro --json
{
    "codename": "",
    "id": "darwin",
    "like": "",
    "version": "22.6.0",
    "version_parts": {
        "build_number": "0",
        "major": "22",
        "minor": "6"
    }
}