Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail on python3.7 #78

Closed
marsam opened this issue Nov 25, 2018 · 3 comments · Fixed by #79
Closed

Tests fail on python3.7 #78

marsam opened this issue Nov 25, 2018 · 3 comments · Fixed by #79

Comments

@marsam
Copy link

marsam commented Nov 25, 2018

SInce async is a reserved keyword since python 3.7, the tests fails on from .async import ... with SyntaxError

effect/effect/test_intents.py

Line 24 in 9946975

from .async import perform_parallel_async

effect/effect/test_intents.py

Line 24 in 9946975

from .async import perform_parallel_async

@radix
Copy link
Contributor

radix commented Nov 27, 2018

Thanks for the report @marsam! I'll try to take a look at it this weekend. If you have any suggestions for how to maintain backwards compatibility while also supporting 3.7 in this case, I would love to hear them!

@radix radix mentioned this issue Dec 1, 2018
Merged
@radix radix closed this as completed in #79 Dec 1, 2018
@radix
Copy link
Contributor

radix commented Dec 1, 2018

version 0.12.0 is now released with python 3.7 support.

@marsam
Copy link
Author

marsam commented Dec 1, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Py3.7 support python-effect/effect
2 participants
@marsam @radix