Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type annotations for escpos image handler #599

Merged
merged 1 commit into from Dec 3, 2023
Merged

Conversation

patkan
Copy link
Member

@patkan patkan commented Dec 3, 2023

Description

Just some type annotations for image.py

Tested with

If applicable, please describe with which device you have tested.

@patkan patkan self-assigned this Dec 3, 2023
Copy link

codecov bot commented Dec 3, 2023

Codecov Report

Merging #599 (e9b6e2a) into master (8274833) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #599      +/-   ##
==========================================
+ Coverage   78.12%   78.13%   +0.01%     
==========================================
  Files          21       21              
  Lines        1609     1610       +1     
  Branches      283      283              
==========================================
+ Hits         1257     1258       +1     
  Misses        276      276              
  Partials       76       76              
Flag Coverage Δ
unittests 77.95% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/escpos/escpos.py 70.00% <ø> (ø)
src/escpos/image.py 100.00% <100.00%> (ø)

@patkan patkan merged commit 9a1699a into master Dec 3, 2023
14 checks passed
@patkan patkan deleted the mypy-types-image-qr branch December 3, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant