Start of a test suite #27
Conversation
|
As I've just mentioned in issue #1, you could also integrate the tests which Manfred Moitzi added for his xlwt3 fork. You need to contact him to officially relicense the tests, because they all say 'License: GPLv3', but he was quite happy to do that when I asked him about xlrd tests. |
|
Would merging this pull request cause problems for either merging in Manfred's tests or #32? I'd like to get some tests in and Travis and Jenkins up and running... |
| __author__ = 'hrwl' | ||
|
|
||
| import unittest | ||
| import six |
There was a problem hiding this comment.
No reliance on six please. We didn't need it for xlrd and I'm keep to keep it the same for xlwt. We just want our own 'compat' module in xlwt/compat.py...
|
I don't think this should really interfere with adding Manfred's tests, though there may be some duplication of testing that it's worth cutting out later. Neither should it be a problem for any effort to support Python 3 - I'd say having some tests is an important step for that. |
|
Nothing came back from @hlawrenz so closing in favour on Menfred's tests, |
I put together some tests to aid in porting to Python 3. Hopefully they're a good starting point. Feedback from those better acquainted with the code would be appreciated. I attempted to make them so that they'll work in both 2 and 3.