Skip to content
This repository has been archived by the owner on May 4, 2020. It is now read-only.

Added Worksheet.use_start_page_number. #55

Closed
wants to merge 1 commit into from

Conversation

egrubbs
Copy link

@egrubbs egrubbs commented Jul 31, 2014

Currently, xlwt hardcodes the Worksheet is hardcoded to always use the Worksheet.start_page_number for the first page of the worksheet when &P is in the header or footer.

If you are printing multiple sheets at once, it is nice to have automatic page numbering, so each successive worksheet starts where the last one left off. It is especially confusing since &N in the header or footer will display the total number of pages for all the sheets selected for printing. This can yield three worksheets being printed out with the header "1 of 3", "1 of 3", "1 of 3" instead of "1 of 3", "2 of 3", "3 of 3".

This patch simply adds a new property to override the value in the BIFFRecord.

@egrubbs
Copy link
Author

egrubbs commented Nov 4, 2014

I don't think this branch failed the Travis CI build because of any changes I made. I don't see why this branch can't be merged.

@cjw296
Copy link
Member

cjw296 commented Apr 13, 2015

No specific objections to this, but you'll need to rebase off master now that python 3 support has landed and make sure the code you submit works with both python 2 and python 3. Some tests would also be a good idea.

@cjw296 cjw296 closed this Apr 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants