Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ip_tracker project uses external 'requests' module instead of the built-in 'http' module #928

Open
sahil-sagwekar2652 opened this issue Oct 31, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@sahil-sagwekar2652
Copy link

Describe the bug
The ip_tracker project uses the 'requests' module which is not built-in in Python.

To Reproduce
Steps to reproduce the behavior:

  1. If the user does not have 'requests' installed the script will return ImportError.

Solution
Instead if we use the built-in http.client module then the script can be run without any additional requirements.

Additional context
There is nothing wrong with the code, this is an enhancement rather than a bug fix

@sahil-sagwekar2652 sahil-sagwekar2652 added the bug Something isn't working label Oct 31, 2022
@sahil-sagwekar2652
Copy link
Author

sahil-sagwekar2652 commented Oct 31, 2022

I have fixed this issue in my branch. Please assign me this issue so that I can make the pull request. @pawangeek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants