Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Starlette version #32

Closed
zoola969 opened this issue May 31, 2022 · 4 comments
Closed

Upgrade Starlette version #32

zoola969 opened this issue May 31, 2022 · 4 comments

Comments

@zoola969
Copy link
Contributor

Expected Behavior

No dependency conflict

Actual Behavior

New Fastapi version causes dependency versions conflict

Steps to Reproduce the Problem

  1. Try to freeze dependencies with Fastapi >= 0.76.0 and gino-starlette
  2. Get an error (pip-tools for example)
    image

Btw, there are newer versions of starlette: 0.20.*
tiangolo/fastapi#4820
tiangolo/fastapi#4936
So, if you just change ^0.17 to ^0.19, it wont work for long

Specifications

  • Python version: 3.10
  • GINO version: 1.0.1
  • Starlette version: 0.19.1
@wwwjfy
Copy link
Member

wwwjfy commented Jun 4, 2022

I'm happy to review any pull requests. Not an active user of starlette myself, it's better to verify everything works.

@hamie96
Copy link

hamie96 commented Jun 6, 2022

I'm happy to review any pull requests. Not an active user of starlette myself, it's better to verify everything works.

I don't seem to have the ability to create a PR, but I tested changing to ^.19 and it didn't break any tests.

@zoola969
Copy link
Contributor Author

@wwwjfy Hi.
A i've created 2 pull requests Bump to 0.19 and Bump to 0.20 (drop Python 3.6 support)
I tested both versions, all work fine
Pls review

@wwwjfy
Copy link
Member

wwwjfy commented Jun 19, 2022

thanks. it's updated.

@wwwjfy wwwjfy closed this as completed Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants