-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump starlette from 0.20.0 to 0.20.1 #4936
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4936 +/- ##
===========================================
- Coverage 100.00% 99.98% -0.02%
===========================================
Files 532 532
Lines 13672 13673 +1
===========================================
- Hits 13672 13671 -1
- Misses 0 2 +2
Continue to review full report at Codecov.
|
📝 Docs preview for commit da0a234 at: https://628a8d16506abb1780f74f8c--fastapi.netlify.app |
📝 Docs preview for commit 2851cfd at: https://629278bfb0f7b638d24a92cd--fastapi.netlify.app |
📝 Docs preview for commit 0b1b0e3 at: https://62927cae5ebee33521176c42--fastapi.netlify.app |
@@ -27,7 +27,7 @@ def __init__( | |||
self.auto_error = auto_error | |||
|
|||
async def __call__(self, request: Request) -> Optional[str]: | |||
api_key: str = request.query_params.get(self.model.name) | |||
api_key = request.query_params.get(self.model.name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
query_params
returns the right type now.
Works as expected when used as a patch in Fedora Rawhide. |
Thanks! This was solved in #4820, so I'll close this one. ☕ |
Python 3.6 needs to be dropped on #4820 for the pipeline to pass.