Fixed #313, remove stack when empty #334
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ctx.reset(token)
, because for now we allow releasing connections in different order, and possibly in different tasks:In this case, both tasks are sharing the same stack, but not reusing each other. The stack was created in
task1
, but cleared out intask2
.ContextVar.reset(token)
requires that the giventoken
was created in the same context (task), therefore cannot be used in this PR.acquire()
if the current one is empty. Other than resource waste, there was another reason came to me not to do so, but as writing this PR I cannot remember the reason :sigh