Forbid empty id for get()

Unless the class explicitly defines it's OK (getRequiresId set to True).
python-gitlab · Jan 2, 2017 · 18415fe · 18415fe
1 parent 8028ec7
commit 18415fe
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/gitlab/objects.py b/gitlab/objects.py
@@ -99,6 +99,8 @@ def get(self, id=None, **kwargs):
         args = self._set_parent_args(**kwargs)
         if not self.obj_cls.canGet:
             raise NotImplementedError
+        if id is None and self.obj_cls.getRequiresId is True:
+            raise ValueError('The id argument must be defined.')
         return self.obj_cls.get(self.gitlab, id, **args)
 
     def list(self, **kwargs):