Merge pull request #1835 from python-gitlab/jlvillal/id_to_encodedid

chore(objects): use `self.encoded_id` where could be a string
python-gitlab · Jan 14, 2022 · 34110dd · 34110dd
2 parents 0788fe6 + c3c3a91
commit 34110dd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/gitlab/v4/objects/groups.py b/gitlab/v4/objects/groups.py
@@ -92,7 +92,7 @@ def transfer_project(self, project_id: int, **kwargs: Any) -> None:
             GitlabAuthenticationError: If authentication is not correct
             GitlabTransferProjectError: If the project could not be transferred
         """
-        path = f"/groups/{self.id}/projects/{project_id}"
+        path = f"/groups/{self.encoded_id}/projects/{project_id}"
         self.manager.gitlab.http_post(path, **kwargs)
 
     @cli.register_custom_action("Group", ("scope", "search"))

diff --git a/gitlab/v4/objects/projects.py b/gitlab/v4/objects/projects.py
@@ -442,7 +442,7 @@ def upload(
             with open(filepath, "rb") as f:
                 filedata = f.read()
 
-        url = f"/projects/{self.id}/uploads"
+        url = f"/projects/{self.encoded_id}/uploads"
         file_info = {"file": (filename, filedata)}
         data = self.manager.gitlab.http_post(url, files=file_info)
 
@@ -539,7 +539,7 @@ def transfer(self, to_namespace: Union[int, str], **kwargs: Any) -> None:
             GitlabAuthenticationError: If authentication is not correct
             GitlabTransferProjectError: If the project could not be transferred
         """
-        path = f"/projects/{self.id}/transfer"
+        path = f"/projects/{self.encoded_id}/transfer"
         self.manager.gitlab.http_put(
             path, post_data={"namespace": to_namespace}, **kwargs
         )